Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand table's default action type to allow reactnode names #3688

Merged
merged 3 commits into from
Jul 2, 2020
Merged

Expand table's default action type to allow reactnode names #3688

merged 3 commits into from
Jul 2, 2020

Conversation

chandlerprall
Copy link
Contributor

@chandlerprall chandlerprall commented Jul 2, 2020 •
edited
Loading

Summary

Creates a work-around path for #3679 by expanding EuiBasicTable's default action's name to allow any React node.

  • updated actions example to include react nodes in action names
  • tested aria-label -> aria-labelledby change in Mac VoiceOver + Chrome
  • added unit test

This does not fix the bug reported in #3679 where 3+ custom actions will trigger a React warning about nested button elements.

Checklist

- [ ] Check against all themes for compatibility in both light and dark modes
- [ ] Checked in mobile
- [ ] Checked in IE11 and Firefox
- [ ] Props have proper autodocs
- [ ] Added documentation
- [ ] Checked Code Sandbox works for the any docs examples

  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

snide
snide reviewed Jul 2, 2020
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally works. I think you might have a small docs issue

src/components/basic_table/default_item_action.tsx Show resolved Hide resolved
src/components/basic_table/action_types.ts Show resolved Hide resolved
@chandlerprall
Copy link
Contributor Author

@snide updated the action's props table

snide
snide approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thompsongl
thompsongl approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; tested locally with a more complex name element (tooltip like what ML will do)

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3688/

@chandlerprall chandlerprall merged commit 03b2249 into elastic:master Jul 2, 2020
@chandlerprall chandlerprall deleted the bug/3679-custom-action-renderers branch July 2, 2020 17:42
@thompsongl thompsongl mentioned this pull request Jul 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thompsongl thompsongl thompsongl approved these changes

@snide snide snide approved these changes

@walterra walterra Awaiting requested review from walterra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chandlerprall @kibanamachine @snide @thompsongl